about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorAlexander Barton <alex@barton.de>2012-05-22 13:29:31 +0200
committerAlexander Barton <alex@barton.de>2012-05-22 13:31:08 +0200
commit7faa3ed7d6613f23e998604461f543e763278f7e (patch)
treec83214c572388de0652a81262327f482b7ab9ed4 /src
parentc9b152fa4119bc0f4ca27a2e163840a1e2dfbbc5 (diff)
downloadngircd-7faa3ed7d6613f23e998604461f543e763278f7e.tar.gz
ngircd-7faa3ed7d6613f23e998604461f543e763278f7e.zip
Pidfile_Create(): Don't leak file descriptor on error path
Detected by cppcheck:
 [src/ngircd/ngircd.c:502]: (error) Resource leak: pidfd
Diffstat (limited to 'src')
-rw-r--r--src/ngircd/ngircd.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/ngircd/ngircd.c b/src/ngircd/ngircd.c
index f28ff05b..8a93bcb0 100644
--- a/src/ngircd/ngircd.c
+++ b/src/ngircd/ngircd.c
@@ -498,7 +498,8 @@ Pidfile_Create(pid_t pid)
 
 	len = snprintf(pidbuf, sizeof pidbuf, "%ld\n", (long)pid);
 	if (len < 0 || len >= (int)sizeof pidbuf) {
-		Log( LOG_ERR, "Error converting pid");
+		Log(LOG_ERR, "Error converting pid");
+		close(pidfd);
 		return;
 	}