about summary refs log tree commit diff
path: root/src/testsuite/stop-server3
diff options
context:
space:
mode:
authorAlexander Barton <alex@barton.de>2024-01-20 16:14:01 +0100
committerAlexander Barton <alex@barton.de>2024-01-20 16:43:54 +0100
commit669d71f3fe4c21f27c329690d74427879d8ee35a (patch)
tree949e8530d5ec0fb7b700be34e80b6578ba61086e /src/testsuite/stop-server3
parentdbfe54ce62f0d877f4e500ab193ab70d889271d5 (diff)
downloadngircd-669d71f3fe4c21f27c329690d74427879d8ee35a.tar.gz
ngircd-669d71f3fe4c21f27c329690d74427879d8ee35a.zip
Explicitly test for the empty string in Channel_UserHasMode()
Basically this is unnecessary, as Channel_UserModes() always returns a
valid pointer and strchr() can deal with an empty (NULL-terminated)
string perfectly fine, bit it makes the code a bit more obvious and
silences the following warning:

  In function ‘Channel_UserHasMode’,
      inlined from ‘Channel_Kick’ at channel.c:384:7:
  channel.c:784:16: warning: ‘strchr’ reading 1 or more bytes from a region
                    of size 0 [-Wstringop-overread]
    784 |         return strchr(Channel_UserModes(Chan, Client), Mode) != NULL;
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This was seen with "gcc (Debian 12.2.0-14) 12.2.0" at least.
Diffstat (limited to 'src/testsuite/stop-server3')
0 files changed, 0 insertions, 0 deletions