about summary refs log tree commit diff
diff options
context:
space:
mode:
authorAlexander Barton <alex@barton.de>2020-05-04 00:55:25 +0200
committerAlexander Barton <alex@barton.de>2020-05-04 00:58:24 +0200
commit52d8fa2c09c36632c1cacd8242e22e9de920ec9f (patch)
tree4e3205cb2e75dfc907514172168ff11988eb04ee
parent1f40776bc166ece8dad0d333905481aa28786cb5 (diff)
downloadngircd-52d8fa2c09c36632c1cacd8242e22e9de920ec9f.tar.gz
ngircd-52d8fa2c09c36632c1cacd8242e22e9de920ec9f.zip
Update Client_SetHostname() to not use strpbrk()
Not sure about the portability of strpbrk() in really ancient OS, and
this was the only place where it became used recently in ngIRCd ...
So let's play it safe! ;-)
-rw-r--r--src/ngircd/client.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/ngircd/client.c b/src/ngircd/client.c
index 1c7bd1ea..67c02604 100644
--- a/src/ngircd/client.c
+++ b/src/ngircd/client.c
@@ -339,9 +339,9 @@ Client_SetHostname( CLIENT *Client, const char *Hostname )
 
 	/* Only cloak the hostmask if it has not yet been cloaked.
 	 * The period or colon indicates it's still an IP address.
-	 * An empty string means a rDNS lookup did not happen (yet).
-         */
-	if (Conf_CloakHost[0] && (!Client->host[0] || strpbrk(Client->host, ".:"))) {
+	 * An empty string means a rDNS lookup did not happen (yet). */
+	if (Conf_CloakHost[0] && (!Client->host[0] || strchr(Client->host, '.')
+				  || strchr(Client->host, ':'))) {
 		char cloak[GETID_LEN];
 
 		strlcpy(cloak, Hostname, GETID_LEN);