From 1784180bf346b6cbea86dabb0e4fdf592b19b012 Mon Sep 17 00:00:00 2001 From: Dana Dahlstrom Date: Sat, 16 Feb 2008 11:27:48 +0000 Subject: Don't send trailing space in MODE messages Under some circumstances ngIRCd currently issues a channel MODE message with a trailing space after the last parameter, which isn't permitted by the grammar in RFC 2812 section 2.3.1: http://tools.ietf.org/html/rfc2812#section-2.3.1 The following patch modifies mode-test.e to expose this, and modifies irc-mode.c to correct it. --- src/testsuite/mode-test.e | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/testsuite') diff --git a/src/testsuite/mode-test.e b/src/testsuite/mode-test.e index 05dffc5c..260cd03c 100644 --- a/src/testsuite/mode-test.e +++ b/src/testsuite/mode-test.e @@ -1,4 +1,4 @@ -# $Id: mode-test.e,v 1.6 2004/03/10 20:40:06 alex Exp $ +# $Id: mode-test.e,v 1.7 2008/02/16 11:27:49 fw Exp $ spawn telnet localhost 6789 expect { @@ -72,7 +72,7 @@ expect { send "mode #channel +v nick\r" expect { timeout { exit 1 } - "@* MODE #channel +v nick" + "@* MODE #channel +v nick\r" } send "mode #channel +I nick1\r" @@ -96,7 +96,7 @@ expect { send "mode #channel -vo nick nick\r" expect { timeout { exit 1 } - "@* MODE #channel -vo nick nick" + "@* MODE #channel -vo nick nick\r" } send "quit\r" -- cgit 1.4.1