From 1a3790c7b16404ff03219638767039e040779dc0 Mon Sep 17 00:00:00 2001
From: Laurent le Beau-Martin <1180863+laurentlbm@users.noreply.github.com>
Date: Tue, 24 Aug 2021 11:06:41 -0400
Subject: [PATCH] Only open external links in a new tab (#380)

---
 app/filter.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/filter.py b/app/filter.py
index 87d00a2..b5fbfbd 100644
--- a/app/filter.py
+++ b/app/filter.py
@@ -255,8 +255,6 @@ class Filter:
             # Temporarily removing all links to that tab for now.
             link.decompose()
             return
-        elif self.new_tab:
-            link['target'] = '_blank'
 
         result_link = urlparse.urlparse(href)
         q = extract_q(result_link.query, href)
@@ -286,6 +284,9 @@ class Filter:
             # Add no-js option
             if self.nojs:
                 append_nojs(link)
+
+            if self.new_tab:
+                link['target'] = '_blank'
         else:
             if href.startswith(MAPS_URL):
                 # Maps links don't work if a site filter is applied