| Age | Commit message (Collapse) | Author |
|---|
|
I thought it'd be fine to store modes as an array. But using this is
awful experience. Take a look at simple NAMES command: it just needs
to check whether some user is oper or voice or not, and with that
approach it will need to iterate over an array of users, and for each
user iterate over an array of modes. Or it is possible to optimize it,
saving all interesting modes to a local buffer and then iterating over
it. But those are attempts to fix broken design
So, instead of array of modes there'll be lots of fields regarding each
mode or kind of mode
From now on (struct Channel).peers is not a simple array of peers, but
the one with metainformation. This is done by making an array of
structures, so there are renames throughout the code
Also, I didn't like that it was users and not peers and this is a nice
opportunity to rename it: in first place this was done to avoid thing
that compiler somehow could silently ignore type change, but this is
also a stylistic change reflecting my view on naming
|
|
The one in user.c is the funniest one
|
|
If user hasn't joined any channels, announcement still should be
delivered to them
|
|
Well, I guess that code is needed more then once, so it'll be good
to move it to some function
|
|
Though they don't have modes, and JOIN/PART must be able to parse
comma separated list of channels
|
|
|