ngircd/src, branch rel-27 ngircd with make http://git.nakidai.ru/ngircd/atom?h=rel-27 2024-04-26T12:29:28+00:00 Explicitely cast NumConnections etc. (size_t) to "long" 2024-04-26T12:29:28+00:00 Alexander Barton alex@barton.de 2024-04-26T12:29:28+00:00 urn:sha1:6cb09e4c98ee8d38b6ca80454df17f1af5167001 This fixes the following compiler warning, for example on OpenSolaris: conn.c: In function 'Conn_Handler': conn.c:798:28: warning: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t' {aka 'unsigned int'} [-Wformat=] Fix channel symbol returned by RPL_NAMREPLY for secret channels 2024-04-19T21:00:20+00:00 Val Lorentz progval+git@progval.net 2024-04-19T21:00:20+00:00 urn:sha1:d4fb21f3542ee2a42aecdddc73a76a6ff41fcacd References: - https://modern.ircdocs.horse/#rplnamreply-353 - https://datatracker.ietf.org/doc/html/rfc2812#page-47 - (RFC 1459 is irrelevant here, as https://datatracker.ietf.org/doc/html/rfc1459#page-51 uses a different format) Closes #313. Don't abort startup when setgid/setuid() fails with EINVAL 2024-04-13T18:48:54+00:00 Alexander Barton alex@barton.de 2024-04-13T17:43:54+00:00 urn:sha1:90fb3cf0a2b980acc1958bff315838a50fa4ccbe Both setgid(2) as well as setuid(2) can fail with EINVAL in addition to EPERM, their manual pages state "EINVAL: The user/group ID specified in uid/gid is not valid in this user namespace ". So not only treat EPERM as an "acceptable error" and continue with logging the error, but do the same for EINVAL. This was triggered by the Void Linux xbps-uunshare(1) tool used for building "XBPS source packages" and reported by luca in #ngircd. Thanks! Test suite: Correctly test for LOGNAME and USER 2024-04-13T14:04:29+00:00 Alexander Barton alex@barton.de 2024-04-13T14:04:29+00:00 urn:sha1:b77b9432c45d6f38c0ad6d9021afb4dd91f163e4 Test suite: Don't use "pgrep -u" when LOGNAME and USER are not set 2024-04-13T13:54:06+00:00 Alexander Barton alex@barton.de 2024-04-13T13:52:33+00:00 urn:sha1:a33d15751b3e3910bd06125efbeae6569844f313 Thanks for reporting this on IRC, luca! Test suite: Use $USER in getpid.sh when $LOGNAME is not set 2024-04-13T10:22:35+00:00 Alexander Barton alex@barton.de 2024-04-13T10:00:49+00:00 urn:sha1:e3f96d446dd88241a94de51b676fd118d47ab7d7 The LOGNAME environment variable is not set in GitHub "actions", for example ... Ping the service manager and set a status message 2024-04-05T22:13:13+00:00 Alexander Barton alex@barton.de 2024-04-05T20:48:22+00:00 urn:sha1:791778d7b6e2f0e92c67e6812f85445171c24572 Periodically "ping" the service manager (every 3 seconds) and set a status message showing connection statistics. This enables using the systemd(8) watchdog functionality for the "ngircd.service" unit. Add support for the "sd_notify" protocol 2024-04-05T22:12:58+00:00 Alexander Barton alex@barton.de 2024-04-05T20:38:22+00:00 urn:sha1:e4873b4d63d0bcd4914a1cee82599a13cfd77e47 This allows the "ngircd.service" systemd(8) unit to use the "notify" service type, which allows for better status tracking by the service manager. Test suite: wait for ERROR message on QUIT 2024-04-05T21:16:07+00:00 Alexander Barton alex@barton.de 2024-04-02T20:01:00+00:00 urn:sha1:a8a37b681e54cb236f0547961d87bf271db8d536 Wait for the "ERROR :Closing connection" message sent by ngIRCd when handling the QUIT command, do not wait for "Connection closed" which is actually output by the telnet(1) command and is implementation dependant! For example, on Haiku OS, this is not always(!) echoed (the command seems to hang sometimes?) which results in unpredictable failures in the test suite ... Test suite: simplify and enhance getpid.sh 2024-04-05T21:16:07+00:00 Alexander Barton alex@barton.de 2024-04-01T19:38:21+00:00 urn:sha1:22a8744476dff7763cd94954bd8f96fbdfc0d251 - Try to only search for processes of the current user. - Prefer using pgrep (in addition to pidof) when available. - Streamline system overrides. - Get rid of HEAD_FLAGS: all systems so far support "-1". - Use "ps -o pid,comm" as the default, which is POSIX.1. - Use "sort -r" to hopefully get the newest (=highest) PID, which is the case on older systems not using randomized PIDs at least.