ngircd/src, branch rel-26-rc2

Don't send invalid CHANINFO commands when no key is set

2020-06-11T14:45:30+00:00

It can happen that a channel is +k, but no key is set: for example by misconfiguring a pre-defined channel. In this case, ngIRCd sent an invalud CHANINFO command ("CHANINFO #test +Pk 0 :'", note the unset key represented by the two spaces) to its peers. Fix this and enhance the CHANINFO documentation.

IRC_SQUIT(): Fix use-after-free when unregistering the sending client

2020-05-25T22:05:22+00:00

IRC_SERVER: Make sure that the client sent a prefix

2020-05-25T21:51:00+00:00

The SERVER command is only valid with a prefix when received from other servers, so make sure that there is one and disconnect the peer if not (instead of crashing ...). This obsoletes PR #275. Thanks Hilko Bengen (hillu) for finding & reporting this as well for the patch & pull request! But I think this is the "more correct" fix.

Enhance debug logging for PONG commands

2020-05-25T21:30:07+00:00

Distinguish between expected and unexpected PONG commands.

Fix PING-PONG handling when processing backlog in read buffers

2020-05-25T20:59:58+00:00

Prior to this commit, the PONG wasn't registered correctly, becauuse the "last ping" time was set to time(NULL), which could be bigger than the "last data" time stamp, for example when handling the read buffer took more than 1 second -- and this resulted in the PONG time out kicking in effectively disconnecting a newly linked server for example, because ngIRCd thought it was still waiting for a PONG: last data < last ping. Now the "last ping" value has three possible values: 0: new connection, no PING, no PONG so far. 1: got a PONG, no longer waiting for a PONG. : time stamp of last sent out PING command.

Revert "Set the "last data" time to "last ping" time when updating the latter"

2020-05-25T20:59:00+00:00

This patch completely broke the PING-PONG logic: now ngIRCd never disconnects any stale peers but keeps sending out PINGs over and over again ... The real issue (server disconnects right after connect) will be fixed in the next commit, but let's revert to the somewhat "half-broken but 'known' state" first ... This reverts commit 79a917f954bef8089967786bd3597a6e5ff5c336.

testsuite: Add missing files to EXTRA_DIST

2020-05-22T15:23:42+00:00

26~rc1 as extracted from tarball cannot be built/tested with SSL support because of a missing script and certificates.

Allow more characters per line in MOTD and help text files

2020-05-07T16:10:41+00:00

Change the line buffer in the Read_TextFile() function from 127 to COMMAND_LEN (=512) bytes. Lines can't even get that long, because they have to be prefixed before being sent to the client, so this is a sane maximum. This allows for even more "fancy" and "wider" MOTDs :-) Closes #271.

Show allowed channel types in ISUPPORT(005) numeric only

2020-05-07T16:03:06+00:00

Don't show the static list of all possibly available channel types ... Closes #273.

SSL test server: Use port 6790, like "test server #2"

2020-05-06T22:02:00+00:00

Don't use the "standard" IRC SSL port 6697, as this easily collides with real (ng)IRCd instances running on the same machine. And by reusing port 6790, which is already used by the "test server #2", we don't need any other port than the test suite already uses.