ngircd/src, branch rel-25

2019!

2019-01-01T23:10:06+00:00

Implement new configuration option "MaxPenaltyTime" (#251)

2018-11-28T13:13:09+00:00

This option configures the maximum penalty time increase in seconds, per penalty event. Set to -1 for no limit (the default), 0 to disable penalties altogether. ngIRCd doesn't use penalty increases higher than 2 seconds during normal operation, so values higher than 1 rarely make sense. Disabling (or reducing) penalties can greatly speed up "make check" runs for example, see below, but are mostly a debugging feature and normally not meant to be used on production systems! Some example timings running "make check" from my macOS workstation: - MaxPenaltyTime not set: 4:41,79s - "MaxPenaltyTime = 1": 3:14,71s - "MaxPenaltyTime = 0": 25,46s Closes #249.

Fix compilation without deprecated OpenSSL APIs (#252)

2018-11-28T13:10:46+00:00

Fix some compiler warnings of Apple Xcode/Clang

2018-10-30T00:53:24+00:00

For example: * src/ngircd/irc-login.c:102:21: Implicit conversion loses integer precision: 'int' to 'char' * src/ngircd/conn.c:1084:9: Implicit conversion turns floating-point number into integer: 'double' to 'bool' * src/tool/tool.c:85:10: Implicit conversion loses integer precision: 'int' to 'char'

Fix typos/errors/... in file comments

2018-10-30T00:48:31+00:00

Found by Xcode/Clang code analyzer. No functional changes.

Allow a 5th parameter in WEBIRC

2018-10-07T21:33:27+00:00

According to an IRCv3 extension, the 5th parameter can be used for extra flags that are fine to ignore for now, but limiting WEBIRC params to 4 causes a syntax error. See https://github.com/ircv3/ircv3-ideas/issues/12 for more information. This closes #247.

Initialize listening socket: Streamline error message

2018-04-01T00:19:08+00:00

Correctly retry outgoing conenctions when forking a resolver failed

2018-03-25T19:59:01+00:00

When ngIRCd failed to spawn a new resolver subprocess, the connection structure was still marked as "SERVER_WAIT", and no new attempt to connect to this server was made. Thanks to Robert Obermeier for reporting this bug! Closes #243.

Fix use-after-free while handling ERROR during client login

2018-03-11T20:18:38+00:00

This patch fixes a "use after free" bug which is hit while processing ERROR commands while a new client is logging into the server, which leads to only the CLIENT structure becoming freed, but not the CONNECTION structure, too. And this leads to the daemon accessing the already freed CLIENT structure later on ... So now IRC_ERROR() uses the correct function Conn_Close() to correctly free both structures. The CONNECTION structure is cleaned up later on, and the freed CLIENT structure can't be overwritten during normal operations, therefore this bug normally can't crash (DoS) the service -- but you can easily hit it when using the GCC option "-fsanitize=address", or run ngIRCd with Valgrind. Thanks a lot to Joseph Bisch for discovering and reporting this issue!

Only send TOPIC updates to a channel when the topic actually changed

2018-03-11T20:01:45+00:00

This prevents the channel from becoming flooded by unecessary TOPIC update messages, that can happen when IRC services try to enforce a certain topic but which is already set (at least on the local server), for example. Therefore still forward it to all servers, but don't inform local clients (still update setter and timestamp information, though!)