ngircd/src, branch rel-24

Fix handling of connection pool allocation and enlargement

2017-01-18T23:06:46+00:00

The daemon only enlarged its connection pool when accepting new client connections, not when establishing new outgoing server links. Thanks to Lukas Braun (k00mi) for reporting this! In addition this patch streamlines the connection pool allocation, so that there is only one place in the code allocating the pool: the now updated Socket2Index() function. The name doesn't quite fit, but this existing and today quite useless function (because the mapping from socket number to connection index is 1:1 today) already became called in almost all relevant code paths, so I decided to reuse it to keep the patch small ...probably we want to fix the naming in a second patch? Closes #231.

2017!

2017-01-15T21:07:11+00:00

Log privilege violations and failed OPER as "error" and to &server

2016-12-08T00:34:33+00:00

Immediately shut down connection on receiving ERROR

2016-12-08T00:01:40+00:00

Don't wait for the peer to close the connection. This allows us to forward the ERROR mesage in the network, instead of the very generic "client closed connection" message.

x-Line synchronization: Don't send negative durations

2016-12-07T23:22:05+00:00

List expiration: use same log level as when setting

2016-12-07T23:20:38+00:00

And log this event to the &SERVER channel, too.

Remove leftover debug message. Oops!

2016-12-07T23:18:57+00:00

G-LINES: Forbid remote modifications if "AllowRemoteOper" is not set

2016-12-07T23:14:00+00:00

Explicitely forbid remote servers to modify "x-lines" (G-LINES) when the "AllowRemoteOper" configuration option isn't set, even when the command seems to originate from the remote server itself: this prevents GLINE's to become set during server handshake in this case (what wouldn't be possible during regular runtime when a remote IRC Op sends the command) and what can't be undone by IRC Ops later on (because of the missing "AllowRemoteOper" option) ...

Fix building ngIRCd with OpenSSL 1.1

2016-12-05T22:51:07+00:00

At the moment, ngIRCd fails to build against OpenSSL 1.1 since the configure check probes for the SSL_library_init symbol which was removed, but probing for a different function availabe in both versions solves that problem: SSL_new(). And as SSL_library_init is no longer needed, the patch boils down to probing SSL_new to assert libssl is available, and disabling the SSL_library_init invokation from OpenSSL 1.1 on, see also another application[1] (NSCA-ng) that did pretty much the same. Patch was compile-tested on both Debian jessie (OpenSSL 1.0.2) and stretch (OpenSSL 1.1). [1] (Patch by Christoph, commit message cherry-picked from the email thread on the mailing list by Alex. Thanks!)

gcc 6.2 warnings: fix code indentation

2016-12-05T22:33:12+00:00

This fixes the following correct -Wmisleading-indentation warning messages of gcc 6.2: irc-write.c: In function ‘IRC_SendWallops’: irc-write.c:521:4: warning: this ‘if’ clause does not guard... irc-write.c:524:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ irc-write.c:526:4: warning: this ‘if’ clause does not guard... [] irc-write.c:529:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ irc-info.c: In function ‘IRC_STATS’: irc-info.c:895:3: warning: this ‘else’ clause does not guard... irc-info.c:897:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘else’ No functional changes, the code has been correct, but the indentation was wrong ...