ngircd/src/testsuite/message-test.e, branch rel-25-rc1

Send_Message: Fix handling of "empty" targets

2016-01-07T00:54:11+00:00

Clients can specify multiple targets for the "PRIVMSG", "NOTICE", and "SQUERY" commands, separated by commas (e. g. "PRIVMSG a,#b,c :text"). Since commit 49ab79d0 ("Limit the number of message targes, and suppress duplicates"), ngIRCd crashed when the client sent the separator character only as target(s), e. g. "," or ",,,," etc.! This patch fixes the bug and adds a test case for this issue. Thanks to Florian Westphal for spotting the issue!

Limit the number of message targes, and suppress duplicates

2016-01-04T21:15:46+00:00

This prevents an user from flooding the server using commands like this: PRIVMSG nick1,nick1,nick1,... Duplicate targets are suppressed silently (channels and clients). In addition, the maximum number of targets per PRIVMSG/NOTICE/... command are limited to MAX_HNDL_TARGETS (25). If there are more, the daemon sends the new 407 (ERR_TOOMANYTARGETS_MSG) numeric, containing the first target that hasn't been handled any more. Closes #187.

Test suite: Don't use DNS lookups

2014-06-09T00:15:52+00:00

Different operating systems do behave quite differently when doing DNS lookups, for example "127.0.0.1" sometimes resolves to "localhost" and sometimes to "localhost.localdomain" (for example OpenBSD). And other systems resolve "localhost" to the real host name (for example Cygwin). So not using DNS at all makes the test site much more portable.

Test suite: Update file headers and comments

2014-04-17T21:56:36+00:00

Update error messages for user mode +b and channel Mode +M.

2012-10-19T16:38:46+00:00

Replaced error message for channel mode +M with ERR_NEEDREGGEDNICK_MSG (used by Bahamut, inspircd, ircu & Unreal too) and using numeric 477 and the msg simliar like inspircd. Replaced the error message ERR_CANNOTSENDTONICK_MSG for user mode +b with ERR_NONONREG_MSG and using numeric 486, similar like unrealircd. (cherry picked from commit 55a61ab17f63a9e757b7c7598c31b98ce5a132e8 and commit 3737d9ab7da1ea0485cefc07c65dc5308bf0db02)

Test suite: add test for user mode "b"

2012-10-08T10:15:34+00:00

PRIVMSG/NOTICE: handle nick!user@host masks case-insensitive

2012-01-21T12:21:36+00:00

And enhance our test suite to check this a little bit better :-)

message-test: Disable two tests using "localhost" as host name

2008-07-27T16:03:13+00:00

Some operating systems, for example OpenBSD and OpenSolaris, use "localhost." instead of just "localhost" for 127.0.0.1, so the "message-test" using "localhost" failed on such systems. Don't have an idee how to make this work on all platforms ... :-/ So I simply disabled the two affected tests to make the testsuite run on OpenBSD and OpenSolaris again.

Cleaned up PRIVMSG and NOTICE patches.

2008-07-26T23:23:20+00:00

Cumulative Message Patch

2008-07-26T23:23:04+00:00